-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60681/#review189379
-----------------------------------------------------------




subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/tree/GlossaryTreeElement.java
Lines 64 (patched)
<https://reviews.apache.org/r/60681/#comment266450>

    What do these permissions mean in a GlossaryTreeElement? Permission enum 
has following values: WRITE, UPDATE, DELETE. It is not clean how this will be 
used.



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 60 (patched)
<https://reviews.apache.org/r/60681/#comment266445>

    I don't think it is necessary to duplicate AtlasPerfTracer implementation 
for OMAS implementation. OMAS implementations can continue to use 
AtlasPerfTracer from atlas-common.jar



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 74 (patched)
<https://reviews.apache.org/r/60681/#comment266448>

    For all REST API implemetations, please add enter/exit logs, which print 
the parameters. This will be extremely helpful in troubleshooting issues.
    
    {
      if (LOG.isDebugEnabled()) {
        LOG.debug("==> getGlossaryTreeElement(id={})", id);
      }
    
      GlossaryTreeElement ret = null;
    
      // ...
    
      if (LOG.isDebugEnabled()) {
        LOG.debug("<== getGlossaryTreeElement(id={}): {}", id, ret);
      }
    
      return ret;
    }



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 102 (patched)
<https://reviews.apache.org/r/60681/#comment266451>

    List<GlossaryTreeElement> ==> AtlasGlossaryTreeElements



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 103 (patched)
<https://reviews.apache.org/r/60681/#comment266453>

    Please verify if GET can handle parameters of type 
"List<GlossaryOMASCategory>".
    
    Also, review queryParam names for consistency: line #103 'omasCatagory'; 
line #139 'omasCategories'



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 173 (patched)
<https://reviews.apache.org/r/60681/#comment266454>

    It is unclear how 'limit, offset, sortAttribute, sortAscending' would be 
used, given this method returns a single object.



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 205 (patched)
<https://reviews.apache.org/r/60681/#comment266455>

    It is unclear how 'limit, offset, sortAttribute, sortAscending' would be 
used, given this method returns a single object.



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 238 (patched)
<https://reviews.apache.org/r/60681/#comment266456>

    It is unclear how 'limit, offset, sortAttribute, sortAscending' would be 
used, given this method returns a single object.



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 343 (patched)
<https://reviews.apache.org/r/60681/#comment266458>

    Consider using a map parameter, so that multiple attributes be updated in a 
single call:
    
    @PUT
    public Term updateTermAttributesByGuid(String termGuid, Map<String, Object> 
attributes)
    
    I would sugges similar changes for other partialUpdate* methods as well.



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 440 (patched)
<https://reviews.apache.org/r/60681/#comment266459>

    deletecategoryByGuid ==> deleteCategoryByGuid



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 462 (patched)
<https://reviews.apache.org/r/60681/#comment266460>

    deleteglossaryByGuid ==> deleteGlossaryByGuid



webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java
Lines 508 (patched)
<https://reviews.apache.org/r/60681/#comment266461>

    Is it necessary to have classification method for each of these types: 
term, category, glossary? Why not use a method that handles all these types?
    
    addClassifications(String objGuid, List<Classification> classifications)
    updateClassifications(String objGuid, List<Classification> classifications)
    deleteClassification(String objGuid, String classification)


- Madhan Neethiraj


On Oct. 19, 2017, 4 p.m., David Radley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60681/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 4 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This is stub code to generate some Glossary OMAS REST interfaces. 
> 
> It does not include : 
> - lineage
> 
> This patch is not to be committed at this time- it is for review purposes 
> only.
> 
> 
> Diffs
> -----
> 
>   build-tools/src/main/resources/enunciate.xml dafd66f9 
>   pom.xml f01c3418 
>   subjectarea-omas/pom.xml PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/category/Category.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/Classification.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/EmbeddedMedia.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/Entity.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/MediaUsage.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/PList.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/Permission.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/Reference.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/Relatable.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/Relationship.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/SearchFilter.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/common/Status.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/exception/OMASBaseException.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/exception/OMASErrorCode.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/glossary/Anchor.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/glossary/Glossary.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/graph/GlossaryGraph.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/graph/GlossaryGraphEdge.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/graph/GlossaryGraphEdgeDirection.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/graph/GlossaryGraphNode.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/graph/Graphformat.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/ExternalGlossaryLink.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/RelatedTerms/Antonym.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/RelatedTerms/ISA.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/RelatedTerms/PreferedTerm.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/RelatedTerms/RelatedTerm.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/RelatedTerms/RelatedTerms.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/RelatedTerms/ReplacementTerm.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/RelatedTerms/Synonym.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/RelatedTerms/Translation.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/RelatedTerms/ValidValue.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/SemanticAssignment/SemanticAssignment.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/Term.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/TermRelationshipStatus.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/contexts/Context.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/spineObjects/SpineObjects.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/spineObjects/TermHASARelationship.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/spineObjects/TermISATYPEOFRelationship.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/spineObjects/TermSpineRelationship.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/spineObjects/TermTYPEDBYRelationship.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/term/termCategorization/TermCategorization.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/tree/GlossaryOMASCategory.java
>  PRE-CREATION 
>   
> subjectarea-omas/src/main/java/org/apache/atlas/omas/subjectarea/tree/GlossaryTreeElement.java
>  PRE-CREATION 
>   webapp/pom.xml 7a868086 
>   webapp/src/main/java/org/apache/atlas/web/rest/SubjectAreaOMASREST.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60681/diff/10/
> 
> 
> Testing
> -------
> 
> generated the swagger by running mvn clean install -DskipTests 
> -DskipEnunciate=false. 
> the output is in file:///<<GIT_HOME>>/webapp/target/api/v2/apidocs/index.html
> where <<GIT_HOME>> is where you ran the Maven build.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Reply via email to