----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61502/ -----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian. Bugs: ATLAS-2025 https://issues.apache.org/jira/browse/ATLAS-2025 Repository: atlas Description ------- Right now there's no such validation and as a (unwanted) side-effect the following happens 1. Internal error when type name is invalid (NPE) 2. Type is valid but classification is invalid - the result contains entities which don't have the tag (exactly opposite behavior) Diffs ----- repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 66dd7484 repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 929f8d00 Diff: https://reviews.apache.org/r/61502/diff/1/ Testing ------- Validated the correctness of results using curl/postman calls, any invalid type name / classification throws 400 now. mvn clean package -Pdist,berkeley-elasticsearch executes successfully Thanks, Apoorv Naik