-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61502/#review182562
-----------------------------------------------------------




webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
Line 215 (original), 215 (patched)
<https://reviews.apache.org/r/61502/#comment258469>

    I suggest creating a new AtlasErrorcode with the text 
       attrName : {0}, attrValue: {1} for attribute search."
       
    At the moment there are 2 template replacements, I suggest using the one in 
AtlasErrorcode. It is also good practise to have error numbers that can only 
come from one place in the code - to ease debugging.


- David Radley


On Aug. 9, 2017, 5:51 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61502/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2017, 5:51 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2025
>     https://issues.apache.org/jira/browse/ATLAS-2025
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Right now there's no such validation and as a (unwanted) side-effect the 
> following happens
> 
> 1. Internal error when type name is invalid (NPE)
> 2. Type is valid but classification is invalid - the result contains entities 
> which don't have the tag (exactly opposite behavior)
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java b24f99f6 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  66dd7484 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 929f8d00 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 71860a17 
> 
> 
> Diff: https://reviews.apache.org/r/61502/diff/3/
> 
> 
> Testing
> -------
> 
> Validated the correctness of results using curl/postman calls, any invalid 
> type name / classification throws 400 now.
> 
> mvn clean package -Pdist,berkeley-elasticsearch executes successfully
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Reply via email to