----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/#review182676 -----------------------------------------------------------
distro/src/bin/atlas_config.py Lines 71 (patched) <https://reviews.apache.org/r/61561/#comment258666> I am uncomfortable duplicating the default port values here. I suggest moving this logic to the java class that already has the default port values distro/src/bin/atlas_config.py Lines 454 (patched) <https://reviews.apache.org/r/61561/#comment258667> is this going to work if -port was specified on the atlas_start command? distro/src/bin/atlas_config.py Lines 473 (patched) <https://reviews.apache.org/r/61561/#comment258663> I was hoping we would be able to be notified when Atlas was started or the startup time reduced, by understanding why there is a delay and minimizing it. Once we understand that and decide that polling is the appropriate resolution - I suggest a 1 second poll - as we can do nothing with Atlas until it is started. distro/src/bin/atlas_config.py Lines 475 (patched) <https://reviews.apache.org/r/61561/#comment258664> I am not expert on all the ways Atlas can be started, does this work with OAuth and does Knox work with this? distro/src/bin/atlas_config.py Lines 477 (patched) <https://reviews.apache.org/r/61561/#comment258665> If we have failures during startup, how can we tell the polling to cease? - David Radley On Aug. 10, 2017, 5:47 p.m., Richard Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61561/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 5:47 p.m.) > > > Review request for atlas, David Radley, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-1218 > https://issues.apache.org/jira/browse/ATLAS-1218 > > > Repository: atlas > > > Description > ------- > > This patch implements a wait_for_startup function modeled after > wait_for_shutdown function. > > > Diffs > ----- > > distro/src/bin/atlas_config.py 1be9ca2b > distro/src/bin/atlas_start.py a6a3455c > > > Diff: https://reviews.apache.org/r/61561/diff/1/ > > > Testing > ------- > > Here are the output of atlas_start and atlas_stop script: > ``` > starting atlas on port 21000 > ........................................................................................................................ > Apache Atlas Server started!!! > ``` > and > ``` > stopping atlas........ > Apache Atlas Server stopped!!! > ``` > > > Thanks, > > Richard Ding > >
