----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/#review183822 -----------------------------------------------------------
distro/src/bin/atlas_config.py Lines 474 (patched) <https://reviews.apache.org/r/61561/#comment259891> Instead hardcoding "localhost", use the config value of "atlas.server.bind.address". Only when this config is not set, "localhost" should be used. I see that "localhost" would work currently, as Atlas server listens on all IP addresses in the host - due to the following line in EmbeddedServer.getConnector(): connector.setHost("0.0.0.0"); This needes to be fixed to use the value specified in this configuration. I suggest we fix this via another JIRA. - Madhan Neethiraj On Aug. 16, 2017, 11:15 p.m., Richard Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61561/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 11:15 p.m.) > > > Review request for atlas, David Radley, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-1218 > https://issues.apache.org/jira/browse/ATLAS-1218 > > > Repository: atlas > > > Description > ------- > > This patch implements a wait_for_startup function modeled after > wait_for_shutdown function. > > > Diffs > ----- > > distro/src/bin/atlas_config.py 1be9ca2b > distro/src/bin/atlas_start.py a6a3455c > > > Diff: https://reviews.apache.org/r/61561/diff/4/ > > > Testing > ------- > > Here are the output of atlas_start and atlas_stop script: > ``` > starting atlas on port 21000 > ........................................................................................................................ > Apache Atlas Server started!!! > ``` > and > ``` > stopping atlas........ > Apache Atlas Server stopped!!! > ``` > > > Thanks, > > Richard Ding > >
