> On Aug. 25, 2017, 9:55 a.m., Nigel Jones wrote:
> > distro/src/bin/atlas_start.py
> > Lines 134 (patched)
> > <https://reviews.apache.org/r/61561/diff/4/?file=1798972#file1798972line134>
> >
> > I notice we have a hardcoded max time of 5 minutes. I wonder if there's
> > any scenarios where we might expect longer, and whether we need to add a
> > -maxtime nn parameter ?
> >
> > As this is a script which the user can edit I'm not overly concerned
> > but thought it worth mentioning
Thanks Nigel. It's hard to determine the timeout value. I've talked to Ambari
developers about how Ambari handles service startup. Ambari delegates service
startup functions to the service (as defined in Ambari common services). For
example, Atlas service has following:
```
<commandScript>
<script>scripts/metadata_server.py</script>
<scriptType>PYTHON</scriptType>
<timeout>1200</timeout>
</commandScript>
```
Each service also provides a server_check script which Ambari runs periodically
to check server status. Atlas uses following command:
```
smoke_cmd = format('curl -k -s -o /dev/null -w "%{{http_code}}"
{metadata_protocol}://{atlas_host}:{metadata_port}/')
```
This is similar to what we proposed.
- Richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61561/#review183837
-----------------------------------------------------------
On Aug. 16, 2017, 11:15 p.m., Richard Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61561/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2017, 11:15 p.m.)
>
>
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath
> Subramanian.
>
>
> Bugs: ATLAS-1218
> https://issues.apache.org/jira/browse/ATLAS-1218
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch implements a wait_for_startup function modeled after
> wait_for_shutdown function.
>
>
> Diffs
> -----
>
> distro/src/bin/atlas_config.py 1be9ca2b
> distro/src/bin/atlas_start.py a6a3455c
>
>
> Diff: https://reviews.apache.org/r/61561/diff/4/
>
>
> Testing
> -------
>
> Here are the output of atlas_start and atlas_stop script:
> ```
> starting atlas on port 21000
> ........................................................................................................................
> Apache Atlas Server started!!!
> ```
> and
> ```
> stopping atlas........
> Apache Atlas Server stopped!!!
> ```
>
>
> Thanks,
>
> Richard Ding
>
>
