----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62110/#review184744 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java Line 91 (original), 92 (patched) <https://reviews.apache.org/r/62110/#comment260945> constructInMemoryPredicate() method was setting 'inMemoryPredicate'. Why this change? This breaks other callers of this method - like EntitySearchProcessor.java line #80. Please revert this change. repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java Line 98 (original), 99 (patched) <https://reviews.apache.org/r/62110/#comment260944> Consider the following renaming for better readability: 'allGraphQueryWithoutFilters' ==> 'entityGraphQueryWithTagFilter' (this query returns entity vertices) 'allGraphQueryWithFilters' ==> 'tagGraphQueryWithAttributesFilter' (this query returns classification vertices) repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java Lines 207 (patched) <https://reviews.apache.org/r/62110/#comment260943> this 'if' block is applicable even when indexQuery == null - if the block #192 - #198 is executed. I think this condition should be: if (CollectionUtils.isNotEmpty(classificationVertices)) - Madhan Neethiraj On Sept. 6, 2017, 6:07 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62110/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 6:07 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2115 > https://issues.apache.org/jira/browse/ATLAS-2115 > > > Repository: atlas > > > Description > ------- > > ATLAS-1880 introduced regression in call timings for the basic search GET > implementation > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 0daab030 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > a4a638af > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > d5e39236 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > fc973e6f > > > Diff: https://reviews.apache.org/r/62110/diff/1/ > > > Testing > ------- > > Tested via scripts and network call timing in Chrome/Firefox. > > > Thanks, > > Apoorv Naik > >
