----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62110/#review184815 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Lines 108 (patched) <https://reviews.apache.org/r/62110/#comment261001> given classification filter is already added to 'query' in line #107, it is necessary to add a predicate for the same in 'graphQueryPredicate'? repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Lines 124 (patched) <https://reviews.apache.org/r/62110/#comment261002> Shuldn't this be: "graphQueryPredicate = attributePredicate;" repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Lines 129 (patched) <https://reviews.apache.org/r/62110/#comment261003> given state filter is already added to 'graphQuery' in line #126, it is necessary to add a predicate for the same in 'graphQueryPredicate'? repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Lines 142 (patched) <https://reviews.apache.org/r/62110/#comment261004> This predicate should be added to 'filterGraphQueryPredicate' and not 'graphQueryPredicate'. - Madhan Neethiraj On Sept. 6, 2017, 11:11 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62110/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 11:11 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2115 > https://issues.apache.org/jira/browse/ATLAS-2115 > > > Repository: atlas > > > Description > ------- > > ATLAS-1880 introduced regression in call timings for the basic search GET > implementation > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 0daab030 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > a4a638af > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > d5e39236 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > fc973e6f > > > Diff: https://reviews.apache.org/r/62110/diff/2/ > > > Testing > ------- > > Tested via scripts and network call timing in Chrome/Firefox. > > > Thanks, > > Apoorv Naik > >
