> On Sept. 29, 2017, 10:33 p.m., Sarath Subramanian wrote: > > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > > Line 349 (original), 349 (patched) > > <https://reviews.apache.org/r/62679/diff/4/?file=1839864#file1839864line349> > > > > BEGINS_WITH is specified in both line 348 and 349 -> should it be > > ENDS_WITH?
Good catch Sarath. - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62679/#review186750 ----------------------------------------------------------- On Sept. 29, 2017, 4:49 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62679/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2017, 4:49 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2184 > https://issues.apache.org/jira/browse/ATLAS-2184 > > > Repository: atlas > > > Description > ------- > > Search parameters in basic search now include is_null, not_null operators > which can prove useful in scenarios where user is interested in checking the > presence/absence of certain entity attributes > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > a7a71b78 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > b380e1e4 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > 18d77ee7 > > > Diff: https://reviews.apache.org/r/62679/diff/4/ > > > Testing > ------- > > Tested using various combinations of attributes and IS_NULL/NOT_NULL operator > via REST client/ curl > > > Thanks, > > Apoorv Naik > >
