-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62679/
-----------------------------------------------------------

(Updated Sept. 30, 2017, 1:19 a.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

1. Added null checks for handling null attrVal in POST request
2. Added missing constructs for case when complete gremlin query is used to 
search


Bugs: ATLAS-2184
    https://issues.apache.org/jira/browse/ATLAS-2184


Repository: atlas


Description
-------

Search parameters in basic search now include is_null, not_null operators which 
can prove useful in scenarios where user is interested in checking the 
presence/absence of certain entity attributes


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
a7a71b78 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
b380e1e4 
  
repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 
33f9b7ab 
  repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 
a6025293 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
18d77ee7 


Diff: https://reviews.apache.org/r/62679/diff/6/

Changes: https://reviews.apache.org/r/62679/diff/5-6/


Testing
-------

Tested using various combinations of attributes and IS_NULL/NOT_NULL operator 
via REST client/ curl


Thanks,

Apoorv Naik

Reply via email to