----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64061/#review191861 -----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java Lines 102 (patched) <https://reviews.apache.org/r/64061/#comment269801> - consider renmaing 'allowLowerCase' ==> 'convertHdfsPathToLowerCase' - consider marking this as 'final' addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java Lines 130 (patched) <https://reviews.apache.org/r/64061/#comment269802> Consider renaming the property as 'hdfs_path.convert_to_lowercase' addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java Line 298 (original), 308 (patched) <https://reviews.apache.org/r/64061/#comment269806> Handle case-conversion of 'tableLocation' here, before calling fillHDFSDataSet(). addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java Lines 596 (patched) <https://reviews.apache.org/r/64061/#comment269805> Changes in this method, fillHDFSDataSet(), are not necessary, since the caller of this method handles the case conversion details. Please revert. addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java Line 747 (original), 747 (patched) <https://reviews.apache.org/r/64061/#comment269803> This call to lower() needs to be updated as well, similar to line #796 below. - Madhan Neethiraj On Nov. 24, 2017, 1:15 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64061/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2017, 1:15 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2276 > https://issues.apache.org/jira/browse/ATLAS-2276 > > > Repository: atlas > > > Description > ------- > > This patch include fix for Path value for hdfs_path type entity which is set > to lower case from hive-bridge. > Added a new property *atlas.hook.hive.hdfs_path.allowlowercase* if set to > true, then the path will be set to lowercase, else by default the path value > will same as hdfs filename. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > ab0094b8 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 57f5efb5 > > > Diff: https://reviews.apache.org/r/64061/diff/1/ > > > Testing > ------- > > HiveBridge unittest-cases running properly. > Create table and verified the hive/hdfs_path entities in Atlas. > Tested import-hive script and verified the hive/hdfs_path entities in Atlas. > > > Thanks, > > Nixon Rodrigues > >
