----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64061/#review191920 -----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java Lines 130 (patched) <https://reviews.apache.org/r/64061/#comment269856> Given the current implementation converts the path to lower case, default value of 'true' seems to be appropriate. Please review. addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java Line 750 (original), 750 (patched) <https://reviews.apache.org/r/64061/#comment269855> Consider having pathUri the lower case path (when dgiBridge.isConvertHdfsPathToLowerCase() == true), instead of creating another variable locationForHdfs, for this. This will ensure that the look-up at #749 will use the correct-cased path string. - Madhan Neethiraj On Nov. 27, 2017, 4:19 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64061/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2017, 4:19 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2276 > https://issues.apache.org/jira/browse/ATLAS-2276 > > > Repository: atlas > > > Description > ------- > > This patch include fix for Path value for hdfs_path type entity which is set > to lower case from hive-bridge. > Added a new property *atlas.hook.hive.hdfs_path.allowlowercase* if set to > true, then the path will be set to lowercase, else by default the path value > will same as hdfs filename. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > ab0094b8 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 57f5efb5 > > > Diff: https://reviews.apache.org/r/64061/diff/2/ > > > Testing > ------- > > HiveBridge unittest-cases running properly. > Create table and verified the hive/hdfs_path entities in Atlas. > Tested import-hive script and verified the hive/hdfs_path entities in Atlas. > > > Thanks, > > Nixon Rodrigues > >
