-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65178/#review195464
-----------------------------------------------------------


Fix it, then Ship it!





test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java
Line 126 (original), 137 (patched)
<https://reviews.apache.org/r/65178/#comment274641>

    remove getClassLoader() method if not used.


- Sarath Subramanian


On Jan. 16, 2018, 8:21 a.m., Graham Wallis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65178/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2018, 8:21 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2370 - LocalSolrRunner resource loading for Windows
> 
> 
> Diffs
> -----
> 
>   test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java 
> ed8e9e16d50b82cce617c3be891ecfc0a04549b2 
> 
> 
> Diff: https://reviews.apache.org/r/65178/diff/1/
> 
> 
> Testing
> -------
> 
> Ran full build with UTs and ITs.
> mvn clean package 
> (no profiles specified, no skipTests).
> Previously all LocalSolr related tests were failing; now passing.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Reply via email to