> On Jan. 16, 2018, 5:24 p.m., Sarath Subramanian wrote: > > test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java > > Line 126 (original), 137 (patched) > > <https://reviews.apache.org/r/65178/diff/1/?file=1940508#file1940508line137> > > > > remove getClassLoader() method if not used.
Hi Sarath - Thanks for spotting this - I was going to update the patch with getClassLoader removed but I see you have committed it as-is. Are you sure you don't want me to remove the method? If so I will drop this issue, but I'm happy to generate a new patch. - Graham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65178/#review195464 ----------------------------------------------------------- On Jan. 16, 2018, 4:21 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65178/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2018, 4:21 p.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > ATLAS-2370 - LocalSolrRunner resource loading for Windows > > > Diffs > ----- > > test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java > ed8e9e16d50b82cce617c3be891ecfc0a04549b2 > > > Diff: https://reviews.apache.org/r/65178/diff/1/ > > > Testing > ------- > > Ran full build with UTs and ITs. > mvn clean package > (no profiles specified, no skipTests). > Previously all LocalSolr related tests were failing; now passing. > > > Thanks, > > Graham Wallis > >
