> On March 5, 2018, 7:40 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > > Lines 335 (patched) > > <https://reviews.apache.org/r/65911/diff/1/?file=1971569#file1971569line335> > > > > removeTagPropagation() expects a classificationVertex as argument; is > > the instanceVertex here a classificationVertex?
Yes, in this context - the vertex to delete is a classificationVertex. If the vertex is of type trait, delete the edge, trait vertex and all propagated edges - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65911/#review198679 ----------------------------------------------------------- On March 5, 2018, 7:34 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65911/ > ----------------------------------------------------------- > > (Updated March 5, 2018, 7:34 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2480 > https://issues.apache.org/jira/browse/ATLAS-2480 > > > Repository: atlas > > > Description > ------- > > When deleting the table with lineage and tag, propagated edges also needs to > be removed and impacted entity vertices needs to be updated. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 9d56fa96 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 2b62a687 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 0ba06b94 > > > Diff: https://reviews.apache.org/r/65911/diff/1/ > > > Testing > ------- > > > Thanks, > > Sarath Subramanian > >
