----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65911/#review198681 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java Lines 338 (patched) <https://reviews.apache.org/r/65911/#comment278925> there is another deleteTypeVertex() method, with additional parameter 'boolean force'. Shouldn't removeTagPropagation() be called from there as well? Please review. - Madhan Neethiraj On March 6, 2018, 3:34 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65911/ > ----------------------------------------------------------- > > (Updated March 6, 2018, 3:34 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2480 > https://issues.apache.org/jira/browse/ATLAS-2480 > > > Repository: atlas > > > Description > ------- > > When deleting the table with lineage and tag, propagated edges also needs to > be removed and impacted entity vertices needs to be updated. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 9d56fa96 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 2b62a687 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 0ba06b94 > > > Diff: https://reviews.apache.org/r/65911/diff/2/ > > > Testing > ------- > > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/139/console > > > Thanks, > > Sarath Subramanian > >
