> On March 8, 2018, 6:02 p.m., Apoorv Naik wrote: > > distro/pom.xml > > Lines 252 (patched) > > <https://reviews.apache.org/r/65885/diff/1/?file=1969111#file1969111line252> > > > > Looks like this will be run for all profiles, can you make this > > specific to cassandra profile ?
Does it matter here? This just downloads the resource. It will only be used if the embedded-cassandra-solr dist profile is used, otherwise the download is ignored. - Pierre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review198890 ----------------------------------------------------------- On March 2, 2018, 4:51 p.m., Pierre Padovani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65885/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 4:51 p.m.) > > > Review request for atlas and David Radley. > > > Bugs: ATLAS-2470 > https://issues.apache.org/jira/browse/ATLAS-2470 > > > Repository: atlas > > > Description > ------- > > This updates pom's to add the needed cassandra jars, and adds a dist profile > embedded-cassandra-solr. > > > Diffs > ----- > > distro/pom.xml 0103bef6 > distro/src/bin/atlas_config.py e6415cf4 > distro/src/bin/atlas_start.py 39be6b7c > distro/src/bin/atlas_stop.py 66edd904 > distro/src/conf/cassandra.yml PRE-CREATION > distro/src/conf/zookeeper/log4j.properties PRE-CREATION > distro/src/conf/zookeeper/zoo.cfg PRE-CREATION > distro/src/main/assemblies/standalone-package.xml 1881082e > docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 > graphdb/janus/pom.xml 143b775f > > > Diff: https://reviews.apache.org/r/65885/diff/1/ > > > Testing > ------- > > Full build with the new embedded-cassandra-solr, and testing to make sure > Atlas comes up and is functional. > > Be aware that we have been running Cassandra backed JanusGraph for months > with no issues. > > > Thanks, > > Pierre Padovani > >
