> On March 9, 2018, 1:38 a.m., Apoorv Naik wrote: > > distro/pom.xml > > Lines 252 (patched) > > <https://reviews.apache.org/r/65885/diff/1/?file=1969111#file1969111line252> > > > > Although harmless, it's better to even avoid download if it's not > > needed. It's always a good thing to avoid unnecessary jars in the final > > distro, makes troubleshooting easier. > > > > Also this would increase the build time, why to waste CPU/Network > > resources on something if it's not needed.
This was removed from the habase profile in the current patch. The directions for updating a patch were unclear on the wiki, and I had forgotten to update the patch on the review board. > On March 9, 2018, 1:38 a.m., Apoorv Naik wrote: > > distro/src/main/assemblies/standalone-package.xml > > Lines 83 (patched) > > <https://reviews.apache.org/r/65885/diff/1/?file=1969118#file1969118line83> > > > > ZK might be available in certain deployments and this would add > > unnecessary ZK jars to classpath. Potential to cause mess ups in production > > environments. I'm not sure this is the case. The zk directory shows up at the root of the atlas directory, not within the server classpath directory. Additionally, the updated patch only downloads it and installs it if the embedded-cassandra-solr profile is used. So this particular operation is a noop unless that profile is used. - Pierre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review198893 ----------------------------------------------------------- On March 8, 2018, 6:53 p.m., Pierre Padovani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65885/ > ----------------------------------------------------------- > > (Updated March 8, 2018, 6:53 p.m.) > > > Review request for atlas and David Radley. > > > Bugs: ATLAS-2470 > https://issues.apache.org/jira/browse/ATLAS-2470 > > > Repository: atlas > > > Description > ------- > > This updates pom's to add the needed cassandra jars, and adds a dist profile > embedded-cassandra-solr. > > > Diffs > ----- > > distro/pom.xml 0103bef6 > distro/src/bin/atlas_config.py e6415cf4 > distro/src/bin/atlas_start.py 39be6b7c > distro/src/bin/atlas_stop.py 66edd904 > distro/src/conf/atlas-application.properties 355abf44 > distro/src/conf/atlas-env.sh 68b24e93 > distro/src/conf/cassandra.yml.template PRE-CREATION > distro/src/conf/zookeeper/log4j.properties PRE-CREATION > distro/src/conf/zookeeper/zoo.cfg.template PRE-CREATION > distro/src/main/assemblies/standalone-package.xml 1881082e > docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 > graphdb/janus/pom.xml 143b775f > repository/pom.xml b1d6b1f9 > > repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > cee7374e > > repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java > 4d70b7f7 > > repository/src/test/java/org/apache/atlas/repository/audit/CassandraAuditRepositoryTest.java > PRE-CREATION > repository/src/test/resources/cassandra_test.yml PRE-CREATION > > server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java > 7d282b30 > > > Diff: https://reviews.apache.org/r/65885/diff/2/ > > > Testing > ------- > > Full build with the new embedded-cassandra-solr, and testing to make sure > Atlas comes up and is functional. > > Be aware that we have been running Cassandra backed JanusGraph for months > with no issues. > > This patch now includes support for Cassandra as an audit store. I've also > refactored the audit unit tests, and added cassandra specific tests. > > > Thanks, > > Pierre Padovani > >
