> On March 20, 2018, 7:35 p.m., David Radley wrote: > > virtualiser/README.md > > Lines 20 (patched) > > <https://reviews.apache.org/r/66174/diff/1/?file=1983359#file1983359line20> > > > > maily - spelling error > > > > we need to explain what Gaian is, where to get it.
fixed and added introduction of Gaian > On March 20, 2018, 7:35 p.m., David Radley wrote: > > virtualiser/README.md > > Lines 22 (patched) > > <https://reviews.apache.org/r/66174/diff/1/?file=1983359#file1983359line22> > > > > funcitons - spelling error fixed, thanks! > On March 20, 2018, 7:35 p.m., David Radley wrote: > > virtualiser/README.md > > Lines 23 (patched) > > <https://reviews.apache.org/r/66174/diff/1/?file=1983359#file1983359line23> > > > > I suggest not using file - use payload. use payload(json structure) - Yao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66174/#review199553 ----------------------------------------------------------- On March 20, 2018, 2:25 p.m., Yao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66174/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 2:25 p.m.) > > > Review request for atlas, Kees van de Fliert, Mandy Chessell, and Maryna > Strelchuk. > > > Repository: atlas > > > Description > ------- > > Virtualiser has three main funcitons: > 1. listen to Information View OMAS (information-view-out-topic) and retrieve > the json file; > 2. update business logic table and technical logic table, send the updates to > Gaian; > 3. create business view json file and technical view json file, notify > Information View OMAS the update(information-view-in-topic). > > The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-1831 > > > Diffs > ----- > > virtualiser/README.md PRE-CREATION > virtualiser/pom.xml PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/BusinessTerm.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/ColumnContextEvent.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/ColumnDetails.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/Connection.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/DerivedColumnDetail.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/InformationViewEvent.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/KafkaVirtualiser.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasAPICalls.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasAttributes.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasCriterion.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasEntity.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasEntityFilters.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasSearchParameters.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasSearchResponse.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/ffdc/VirtualiserCheckedException.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/ffdc/VirtualiserCheckedExceptionBase.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/ffdc/VirtualiserErrorCode.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/ffdc/VirtualiserRuntimeException.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/gaian/GaianQueryConstructor.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/gaian/LogicTable.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/gaian/MappedColumn.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/kafka/KafkaVirtualiserConsumer.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/kafka/KafkaVirtualiserProducer.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/util/ExecuteQueryUtil.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/util/PropertiesHelper.java > PRE-CREATION > > virtualiser/src/main/java/org/apache/atlas/virtualiser/views/ViewsConstructor.java > PRE-CREATION > virtualiser/src/main/resources/business.json PRE-CREATION > virtualiser/src/main/resources/createEntityinAtlas.json PRE-CREATION > virtualiser/src/main/resources/delete.json PRE-CREATION > virtualiser/src/main/resources/fullAssign.json PRE-CREATION > virtualiser/src/main/resources/input.json PRE-CREATION > virtualiser/src/main/resources/technical.json PRE-CREATION > virtualiser/src/main/resources/testIn.json PRE-CREATION > virtualiser/src/main/resources/virtualiser.properties PRE-CREATION > virtualiser/src/test/java/org/apache/atlas/virtualiser/JsonReadHelper.java > PRE-CREATION > > virtualiser/src/test/java/org/apache/atlas/virtualiser/KafkaVirtualiserProducerForTest.java > PRE-CREATION > > virtualiser/src/test/java/org/apache/atlas/virtualiser/KafkaVirtualiserTest.java > PRE-CREATION > > virtualiser/src/test/java/org/apache/atlas/virtualiser/gaian/GaianQueryConstructorTest.java > PRE-CREATION > > virtualiser/src/test/java/org/apache/atlas/virtualiser/views/ViewsConstructorTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66174/diff/1/ > > > Testing > ------- > > see test folder > > > Thanks, > > Yao Li > >
