> On March 20, 2018, 7:35 p.m., David Radley wrote:
> > virtualiser/src/main/java/org/apache/atlas/virtualiser/views/ViewsConstructor.java
> > Lines 101 (patched)
> > <https://reviews.apache.org/r/66174/diff/1/?file=1983386#file1983386line101>
> >
> >     delete

deleted, thanks


- Yao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66174/#review199553
-----------------------------------------------------------


On March 21, 2018, 6:13 p.m., Yao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66174/
> -----------------------------------------------------------
> 
> (Updated March 21, 2018, 6:13 p.m.)
> 
> 
> Review request for atlas, Kees van de Fliert, Mandy Chessell, and Maryna 
> Strelchuk.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Virtualiser has three main funcitons:
> 1. listen to Information View OMAS (information-view-out-topic) and retrieve 
> the json file;
> 2. update business logic table and technical logic table, send the updates to 
> Gaian;
> 3. create business view json file and technical view json file, notify 
> Information View OMAS the update(information-view-in-topic). 
> 
> The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-1831
> 
> 
> Diffs
> -----
> 
>   virtualiser/README.md PRE-CREATION 
>   virtualiser/pom.xml PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/BusinessTerm.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/ColumnContextEvent.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/ColumnDetails.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/Connection.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/DerivedColumnDetail.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/omas/informationview/events/InformationViewEvent.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/KafkaVirtualiser.java 
> PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasAPICalls.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasAttributes.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasCriterion.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasEntity.java 
> PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasEntityFilters.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasSearchParameters.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/atlas/AtlasSearchResponse.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/ffdc/VirtualiserCheckedException.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/ffdc/VirtualiserCheckedExceptionBase.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/ffdc/VirtualiserErrorCode.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/ffdc/VirtualiserRuntimeException.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/gaian/GaianQueryConstructor.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/gaian/LogicTable.java 
> PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/gaian/MappedColumn.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/kafka/KafkaVirtualiserConsumer.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/kafka/KafkaVirtualiserProducer.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/util/ExecuteQueryUtil.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/util/PropertiesHelper.java
>  PRE-CREATION 
>   
> virtualiser/src/main/java/org/apache/atlas/virtualiser/views/ViewsConstructor.java
>  PRE-CREATION 
>   virtualiser/src/main/resources/business.json PRE-CREATION 
>   virtualiser/src/main/resources/createEntityinAtlas.json PRE-CREATION 
>   virtualiser/src/main/resources/delete.json PRE-CREATION 
>   virtualiser/src/main/resources/fullAssign.json PRE-CREATION 
>   virtualiser/src/main/resources/input.json PRE-CREATION 
>   virtualiser/src/main/resources/technical.json PRE-CREATION 
>   virtualiser/src/main/resources/testIn.json PRE-CREATION 
>   virtualiser/src/main/resources/virtualiser.properties PRE-CREATION 
>   virtualiser/src/test/java/org/apache/atlas/virtualiser/JsonReadHelper.java 
> PRE-CREATION 
>   
> virtualiser/src/test/java/org/apache/atlas/virtualiser/KafkaVirtualiserProducerForTest.java
>  PRE-CREATION 
>   
> virtualiser/src/test/java/org/apache/atlas/virtualiser/KafkaVirtualiserTest.java
>  PRE-CREATION 
>   
> virtualiser/src/test/java/org/apache/atlas/virtualiser/gaian/GaianQueryConstructorTest.java
>  PRE-CREATION 
>   
> virtualiser/src/test/java/org/apache/atlas/virtualiser/views/ViewsConstructorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66174/diff/1/
> 
> 
> Testing
> -------
> 
> see test folder
> 
> 
> File Attachments
> ----------------
> 
> 0009-ATLAS-1831-21-3-2018.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/03/21/8468ad3b-393a-4bd4-b0d6-61df9c8a43fb__0009-ATLAS-1831-21-3-2018.patch
> 
> 
> Thanks,
> 
> Yao Li
> 
>

Reply via email to