----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66203/#review199737 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Lines 1002 (patched) <https://reviews.apache.org/r/66203/#comment280185> I think 'ACTIVE' might be a good choice when edge doesn't have the 'state' property. repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java Lines 161 (patched) <https://reviews.apache.org/r/66203/#comment280186> togglePropagatedClassification() ==> setPropagatedClassificationStateForEntity(entityGuid, classificationName, sourceEntityGuid, propagationState) repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Line 966 (original), 969 (patched) <https://reviews.apache.org/r/66203/#comment280188> Looking for edge by classificationName? How does this handle multiple classifications of the same name being associated with the entity - directly and via propagation? - Madhan Neethiraj On March 21, 2018, 11:47 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66203/ > ----------------------------------------------------------- > > (Updated March 21, 2018, 11:47 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2510 > https://issues.apache.org/jira/browse/ATLAS-2510 > > > Repository: atlas > > > Description > ------- > > Currently there is no way to remove propagated classification from an entity. > This Jira provides capability to disable/enable a propagated classification > from an entity using REST. > > The propagated classification name and its associated entity guid is supplied > to the REST to disable/enable right propagated classification. > > > Disable a propagated tag: > curl -X PUT > 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' > -H 'Authorization: Basic YWRtaW46YWRtaW4=' > > Enable a propagated tag: > curl -X PUT > 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' > -H 'Authorization: Basic YWRtaW46YWRtaW4=' > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c > intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java > 008314b3 > repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 9e8077cb > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 79e8e3e8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > b5461d4b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 18ed533d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 57aa41b4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 38851575 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1 > > > Diff: https://reviews.apache.org/r/66203/diff/1/ > > > Testing > ------- > > Validated disable and enable of propagated classification through REST client > - POSTMAN. > > > Thanks, > > Sarath Subramanian > >
