----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66203/#review200036 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Lines 419 (patched) <https://reviews.apache.org/r/66203/#comment280628> If I have understood correctly; I think the proposal here is that a propogated classification can be disabled - this is implmented using a soft delete. Please could you confirm that any downstream propagated classifications are also disabled? - David Radley On March 27, 2018, 5:26 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66203/ > ----------------------------------------------------------- > > (Updated March 27, 2018, 5:26 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2510 > https://issues.apache.org/jira/browse/ATLAS-2510 > > > Repository: atlas > > > Description > ------- > > Currently there is no way to remove propagated classification from an entity. > This Jira provides capability to disable/enable a propagated classification > from an entity using REST. > > The propagated classification name and its associated entity guid is supplied > to the REST to disable/enable right propagated classification. > > > Disable a propagated tag: > curl -X PUT > 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=true' > -H 'Authorization: Basic YWRtaW46YWRtaW4=' > > Enable a propagated tag: > curl -X PUT > 'http://localhost:21000/api/atlas/v2/entity/guid/0ea86d75-b92c-4907-b149-4fe3fe341cc3/propagatedClassifications/PII?sourceEntityGuid=fb38e88c-c9a8-4fa2-abaa-6be895b067b3&disablePropagation=false' > -H 'Authorization: Basic YWRtaW46YWRtaW4=' > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 605742dd > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4a86670c > intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java > 008314b3 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > fce46da9 > repository/src/main/java/org/apache/atlas/query/GremlinClause.java 454b3434 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > bfb5a711 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 79e8e3e8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > b5461d4b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 19ac6209 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > c76f6405 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 8fe635ae > > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java > 9b4c91d1 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fdafa2c1 > > > Diff: https://reviews.apache.org/r/66203/diff/6/ > > > Testing > ------- > > Validated disable and enable of propagated classification through REST client > - POSTMAN. > > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/213/console > > > Thanks, > > Sarath Subramanian > >
