----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66520/#review200796 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java Lines 612 (patched) <https://reviews.apache.org/r/66520/#comment281690> Instead of storing [ classificationName + ":" + entityGuid ] in the list, it might be efficient to store the vertex ID of the classification instance. Please review. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 463 (patched) <https://reviews.apache.org/r/66520/#comment281688> "else" should be removed, so that BOTH will include #464 as well. Please review. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 969 (patched) <https://reviews.apache.org/r/66520/#comment281689> Consider ignoring badly formatted entries and process the next element in the array. - Madhan Neethiraj On April 10, 2018, 6:16 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66520/ > ----------------------------------------------------------- > > (Updated April 10, 2018, 6:16 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2552 > https://issues.apache.org/jira/browse/ATLAS-2552 > > > Repository: atlas > > > Description > ------- > > Surface currently propagated classifications and blocked propagated > classifications information in the relationship. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 01e49157 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68f > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java > 576847f6 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > 28636d86 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 31f6d821 > > > Diff: https://reviews.apache.org/r/66520/diff/1/ > > > Testing > ------- > > Tested in REST client. GET relationship API yields currently propagated > classifications and blocked propagated classifications > > > Thanks, > > Sarath Subramanian > >
