----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66520/#review200972 -----------------------------------------------------------
Fix it, then Ship it! intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java Lines 197 (patched) <https://reviews.apache.org/r/66520/#comment281891> Instead of casting to List<AtlasClassification>, consider the following: if (CollectionUtils.isNotEmpty((List) propagatedClassifications)) { this.propagatedClassifications = new ArrayList<>(); for (Object elem : (List) propagatedClassifications) { if (elem instanceof AtlasClassification) { this.propagatedClassifications.add((AtlasClassification) elem); } else if (elem instanceof Map) { this.propagatedClassifications.add(new AtlasClassification((Map) elem)); } } } repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 939 (patched) <https://reviews.apache.org/r/66520/#comment281892> setClassifications() => readClassificationsFromEdge() - Madhan Neethiraj On April 12, 2018, 6:07 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66520/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 6:07 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2552 > https://issues.apache.org/jira/browse/ATLAS-2552 > > > Repository: atlas > > > Description > ------- > > Surface currently propagated classifications and blocked propagated > classifications information in the relationship. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 01e49157 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3805c221 > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java > c133e394 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 0c63cec3 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > 28636d86 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 1d945f7f > > > Diff: https://reviews.apache.org/r/66520/diff/4/ > > > Testing > ------- > > Tested in REST client. GET relationship API yields currently propagated > classifications and blocked propagated classifications > > > Thanks, > > Sarath Subramanian > >
