----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66566/#review201044 -----------------------------------------------------------
Fix it, then Ship it! tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/AtlasGraphSONUtility.java Lines 57 (patched) <https://reviews.apache.org/r/66566/#comment281979> 'factory' seems to be unused. Please reivew and consider removing it. tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/AtlasGraphSONUtility.java Lines 251 (patched) <https://reviews.apache.org/r/66566/#comment281980> for consistency, use '{}' for single-line blocks as well. tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/AtlasGraphSONWriter.java Lines 41 (patched) <https://reviews.apache.org/r/66566/#comment281977> consider marking 'graph' as final, since this is not changed after its initialization in the constructor. tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/AtlasGraphSONWriter.java Lines 46 (patched) <https://reviews.apache.org/r/66566/#comment281978> if 'AtlasGraphSONWriter' is not instantiated outside this class, consider marking the constructor as private. tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/AtlasGraphSONWriter.java Lines 50 (patched) <https://reviews.apache.org/r/66566/#comment281976> Marking each parameter as 'final' seem unnecessary. To avoid distractions in reading the code, consider removing these - here and other methods. - Madhan Neethiraj On April 11, 2018, 9:05 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66566/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 9:05 p.m.) > > > Review request for atlas, Madhan Neethiraj and Ruchi Solani. > > > Bugs: ATLAS-2554 > https://issues.apache.org/jira/browse/ATLAS-2554 > > > Repository: atlas > > > Description > ------- > > **Approach** > Modify exisitng _GraphSONWriter_ and _GraphSONUtility_, update data > conversion methods. > > Add metrics nodes to generated JSON. > > > Diffs > ----- > > > tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/AtlasGraphSONUtility.java > PRE-CREATION > > tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/AtlasGraphSONWriter.java > PRE-CREATION > > tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/Exporter.java > 2af8b7d9 > > tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/GraphSONTokens.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66566/diff/1/ > > > Testing > ------- > > **Unit tests** > None. > Output verified as part of imports unit tests. > Use attached file for modifications to _hdfs_path_. > > **Functional tests** > Execute utility with test data. > > > File Attachments > ---------------- > > atlas-migration-typesdef.json > > https://reviews.apache.org/media/uploaded/files/2018/04/11/2402abf4-e1f2-47fc-85d0-6dfa69657e7e__atlas-migration-typesdef.json > > > Thanks, > > Ashutosh Mestry > >
