-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66566/
-----------------------------------------------------------

(Updated April 13, 2018, 12:44 a.m.)


Review request for atlas, Madhan Neethiraj and Ruchi Solani.


Changes
-------

Updates include:
- Addressed review comments.
- Minor refactoring.


Bugs: ATLAS-2554
    https://issues.apache.org/jira/browse/ATLAS-2554


Repository: atlas


Description
-------

**Approach**
Modify exisitng _GraphSONWriter_ and _GraphSONUtility_, update data conversion 
methods.

Add metrics nodes to generated JSON.


Diffs (updated)
-----

  
tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/AtlasGraphSONUtility.java
 PRE-CREATION 
  
tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/AtlasGraphSONWriter.java
 PRE-CREATION 
  
tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/Exporter.java
 2af8b7d9 
  
tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/GraphSONTokens.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/66566/diff/2/

Changes: https://reviews.apache.org/r/66566/diff/1-2/


Testing
-------

**Unit tests**
None. 
Output verified as part of imports unit tests.
Use attached file for modifications to _hdfs_path_.

**Functional tests**
Execute utility with test data.


File Attachments
----------------

atlas-migration-typesdef.json
  
https://reviews.apache.org/media/uploaded/files/2018/04/11/2402abf4-e1f2-47fc-85d0-6dfa69657e7e__atlas-migration-typesdef.json


Thanks,

Ashutosh Mestry

Reply via email to