----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66721/#review201550 -----------------------------------------------------------
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java Lines 73 (patched) <https://reviews.apache.org/r/66721/#comment282846> KAKFA_TOPIC_QUALIFIED_NAME ==> FORMAT_KAKFA_TOPIC_QUALIFIED_NAME addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java Lines 159 (patched) <https://reviews.apache.org/r/66721/#comment282849> ImportKafkaEntities() ==> importTopics() addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java Lines 27 (patched) <https://reviews.apache.org/r/66721/#comment282855> If KAFKA_PARTITION is not being handled currently, I would suggest removing this. addons/models/1000-Hadoop/patches/006-kafka_topic_add_attribute.json Lines 14 (patched) <https://reviews.apache.org/r/66721/#comment282854> Please mark 'isIndexable' as true for: partitionCount, createTime, modifiedTime pom.xml Lines 1499 (patched) <https://reviews.apache.org/r/66721/#comment282845> Artifact kafka-bridge-shim is not built; please review and remove this dependency. - Madhan Neethiraj On April 19, 2018, 7:12 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66721/ > ----------------------------------------------------------- > > (Updated April 19, 2018, 7:12 p.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, Sarath > Subramanian, and Sharmadha Sainath. > > > Repository: atlas > > > Description > ------- > > ATLAS-2586:Provide a utility to Import Kafka Entities into Atlas > > > Diffs > ----- > > addons/kafka-bridge/pom.xml PRE-CREATION > addons/kafka-bridge/src/bin/import-kafka.sh PRE-CREATION > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java > PRE-CREATION > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java > PRE-CREATION > addons/kafka-bridge/src/main/resources/atlas-kafka-import-log4j.xml > PRE-CREATION > addons/models/1000-Hadoop/patches/006-kafka_topic_add_attribute.json > PRE-CREATION > distro/pom.xml 1f4c6d5 > distro/src/main/assemblies/atlas-kafka-hook-package.xml PRE-CREATION > distro/src/main/assemblies/standalone-package.xml dc2a66b > pom.xml a6d1268 > > > Diff: https://reviews.apache.org/r/66721/diff/1/ > > > Testing > ------- > > Verified in local secure cluster. > > Usage 1: import-kafka.sh [-n <topic regex> OR --topic <topic regex >] > Usage 2: import-kafka.sh [-f <filename>] > Format: > topic1 > topic2 > topic3 > > > Thanks, > > Ramesh Mani > >
