----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66721/#review201585 -----------------------------------------------------------
Fix it, then Ship it! addons/kafka-bridge/pom.xml Lines 45 (patched) <https://reviews.apache.org/r/66721/#comment282906> atlas-notification library may not be necessary for a bridge. Please review. Also, review other dependencies listed here; few of them might be required only in test - like hadoop-minicluster; and some of them may not be necessary - like hdfs-model, atlas-notification. addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java Lines 160 (patched) <https://reviews.apache.org/r/66721/#comment282905> Consider renaming this as 'availableTopics' and initialize in the constructor - to avoid calling zkUtils.getAllTopics() multiple times in case of processing topics list from a file. - Madhan Neethiraj On April 19, 2018, 9:56 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66721/ > ----------------------------------------------------------- > > (Updated April 19, 2018, 9:56 p.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, Sarath > Subramanian, and Sharmadha Sainath. > > > Repository: atlas > > > Description > ------- > > ATLAS-2586:Provide a utility to Import Kafka Entities into Atlas > > > Diffs > ----- > > addons/kafka-bridge/pom.xml PRE-CREATION > addons/kafka-bridge/src/bin/import-kafka.sh PRE-CREATION > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java > PRE-CREATION > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java > PRE-CREATION > addons/kafka-bridge/src/main/resources/atlas-kafka-import-log4j.xml > PRE-CREATION > addons/models/1000-Hadoop/patches/006-kafka_topic_add_attribute.json > PRE-CREATION > distro/pom.xml 1f4c6d5 > distro/src/main/assemblies/atlas-kafka-hook-package.xml PRE-CREATION > distro/src/main/assemblies/standalone-package.xml dc2a66b > pom.xml 9c9d746 > > > Diff: https://reviews.apache.org/r/66721/diff/2/ > > > Testing > ------- > > Verified in local secure cluster. > > Usage 1: import-kafka.sh [-n <topic regex> OR --topic <topic regex >] > Usage 2: import-kafka.sh [-f <filename>] > Format: > topic1 > topic2 > topic3 > > > Thanks, > > Ramesh Mani > >
