----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66784/#review201859 -----------------------------------------------------------
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java Line 10962 (original), 10962 (patched) <https://reviews.apache.org/r/66784/#comment283470> attributesTypedBy is clearer omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java Line 10963 (original), 10963 (patched) <https://reviews.apache.org/r/66784/#comment283471> The description should be a sentence in English. This means it starts with a captial letter and does not include camel-case words. I would keep the description the same. - Mandy Chessell On April 24, 2018, 8:48 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66784/ > ----------------------------------------------------------- > > (Updated April 24, 2018, 8:48 p.m.) > > > Review request for atlas, Madhan Neethiraj and Mandy Chessell. > > > Bugs: ATLAS2604 > https://issues.apache.org/jira/browse/ATLAS2604 > > > Repository: atlas > > > Description > ------- > > ATLAS2604 Minor fixups to open metadata archive types to avoid duplicate > attributes due to relationship end names. > > > Diffs > ----- > > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java > faab96cac > > omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66784/diff/1/ > > > Testing > ------- > > Ran junit that failed without the patch applied. I ran this in Intellij using > the Maven view to run the test phase on the OMRS module. This successfully > ran the test. > > > Thanks, > > David Radley > >
