> On April 26, 2018, 1:41 p.m., Mandy Chessell wrote: > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveBuilder.java > > Lines 563 (patched) > > <https://reviews.apache.org/r/66784/diff/2/?file=2012330#file2012330line563> > > > > Please use code layout consistent with the rest of file.
For example - placement of braces - Mandy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66784/#review202004 ----------------------------------------------------------- On April 26, 2018, 12:57 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66784/ > ----------------------------------------------------------- > > (Updated April 26, 2018, 12:57 p.m.) > > > Review request for atlas, Madhan Neethiraj and Mandy Chessell. > > > Bugs: ATLAS2604 > https://issues.apache.org/jira/browse/ATLAS2604 > > > Repository: atlas > > > Description > ------- > > ATLAS2604 Minor fixups to open metadata archive types to avoid duplicate > attributes due to relationship end names. > > > Diffs > ----- > > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveBuilder.java > 5902c4202 > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveHelper.java > 42d2d8746 > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java > faab96cac > omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java 351c910e3 > > omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java > PRE-CREATION > > omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66784/diff/2/ > > > Testing > ------- > > Ran junit that failed without the patch applied. I ran this in Intellij using > the Maven view to run the test phase on the OMRS module. This successfully > ran the test. > > > Thanks, > > David Radley > >
