> On May 9, 2018, 10:46 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
> > Lines 1623 (patched)
> > <https://reviews.apache.org/r/67028/diff/1/?file=2018429#file2018429line1626>
> >
> >     Does JanusGraph support storing map value directly in vertex property? 
> > If yes, perhaps we should replace current handling of map - by storing 
> > entire map in a single property.

Yes JanusGraph supports it, I'll take this up in a new JIRA.


> On May 9, 2018, 10:46 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
> > Line 646 (original), 647 (patched)
> > <https://reviews.apache.org/r/67028/diff/1/?file=2018433#file2018433line649>
> >
> >     Looks like #645 - #658 are needed only if value type is object-id. For 
> > other types  relationshipEdgeLable/EdgeDirection won't be appicable.
> >     
> >     Primitive value-types should already be handled by #635.
> >     Struct type should probably be handled here.
> >     
> >     Similar for mapVertexToArray().
> >     
> >     Please review and update.

refactored this method.


- Sarath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67028/#review202760
-----------------------------------------------------------


On May 9, 2018, 3:26 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67028/
> -----------------------------------------------------------
> 
> (Updated May 9, 2018, 3:26 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2662
>     https://issues.apache.org/jira/browse/ATLAS-2662
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Currently entities with complex types like: array<AtlasEntity>, 
> array<AtlasStruct>, map<String, AtlasStruct>, map<String, AtlasEntity> store 
> list of edge ids in the entity vertex. This JIRA removes all edge id 
> information from vertex and uses edge label and properties to retrieve such 
> attributes.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 16a3aaa15 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5f89ffb59 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> ab5f145af 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 2f870dcd0 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 836710c99 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 7540b4c71 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
>  bd0dc0b44 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  f28d771db 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  172854925 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  0d654712e 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasComplexAttributesTest.java
>  PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  0913e6ff6 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityTestBase.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67028/diff/2/
> 
> 
> Testing
> -------
> 
> Added Unit Test - AtlasComplexAttributesTest to test all complex attributes
> 
> PreCommit: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/361/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Reply via email to