----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67028/#review202810 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Line 1584 (original), 1613 (patched) <https://reviews.apache.org/r/67028/#comment284801> Consider marking this as 'privte', to avoid possible confusion with getMapElementsProperty() above. Or rename: - getMapElements() to getPrimitiveMap() - getMapElementsUsingRelationship() to Map<String, AtlasEdge> getReferenceMap() repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Lines 1645 (patched) <https://reviews.apache.org/r/67028/#comment284802> Call to hasIndexes(), which iterates over all edges, can be avoided by having sortRelationshipElements() treat absence of edge property ATTRIBUTE_INDEX_PROPERTY_KEY as value '0'. - Madhan Neethiraj On May 10, 2018, 12:34 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67028/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 12:34 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Nixon Rodrigues. > > > Bugs: ATLAS-2662 > https://issues.apache.org/jira/browse/ATLAS-2662 > > > Repository: atlas > > > Description > ------- > > Currently entities with complex types like: array<AtlasEntity>, > array<AtlasStruct>, map<String, AtlasStruct>, map<String, AtlasEntity> store > list of edge ids in the entity vertex. This JIRA removes all edge id > information from vertex and uses edge label and properties to retrieve such > attributes. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 16a3aaa15 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5f89ffb59 > intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java > ab5f145af > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 2f870dcd0 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 836710c99 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 7540b4c71 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > bd0dc0b44 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > f28d771db > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 172854925 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 0d654712e > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasComplexAttributesTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 0913e6ff6 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityTestBase.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67028/diff/4/ > > > Testing > ------- > > Added Unit Test - AtlasComplexAttributesTest to test all complex attributes > > PreCommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/361/console > > > Thanks, > > Sarath Subramanian > >
