-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67148/#review203205
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 139 (patched)
<https://reviews.apache.org/r/67148/#comment285299>

    I see qualified name as a unique identifier, being derived from 
referenencable. In one of our meeting we talked of using the guid and name 
here. I thought we talked of deriving a path attribute post v1 - using a new 
generic Atlas mechanism.  
    
    Display name might not be unique, as we want to support categories with the 
same name. I see display name is not the hierarchical path. It should be the 
name. 
    
    On the policing I wonder what happens with janus keywords and whether mixed 
case are viewed as different.


- David Radley


On May 16, 2018, 6:11 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67148/
> -----------------------------------------------------------
> 
> (Updated May 16, 2018, 6:11 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2685
>     https://issues.apache.org/jira/browse/ATLAS-2685
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary & term name can only have letters, spaces, underscores and dashes
> Category can only have letters and spaces
> 
> Added appropriate error codes around this check
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3a609786a 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> bc9fe2a2e 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
> f66165050 
> 
> 
> Diff: https://reviews.apache.org/r/67148/diff/2/
> 
> 
> Testing
> -------
> 
> PreCommit: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/408/console
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Reply via email to