-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67148/#review203206
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 69 (patched)
<https://reviews.apache.org/r/67148/#comment285300>

    I am wondering why the display name is restricted with these characters - 
does it cause a probem? Where would you use the display name in a dotted 
qualfied name? I assume the display name could be Janaese characters - I am not 
sure it would be appropriate to concatinate dots and a Japanese string.  
    
    If you want to restrict it, presumably you need to remove all punctuation 
content in all languages. 
    I suggest you be extra safe for now and only allow upper&lower case case 
letters and blanks - unless you already have nls requirements.
    
    Then extend  as requirements come in. Out of interest I assume that the 
Janus keywords checking could effect what term names can be used.  
    
    Fyi translation is covered in the open metadata model with relationships.


- David Radley


On May 16, 2018, 6:11 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67148/
> -----------------------------------------------------------
> 
> (Updated May 16, 2018, 6:11 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2685
>     https://issues.apache.org/jira/browse/ATLAS-2685
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary & term name can only have letters, spaces, underscores and dashes
> Category can only have letters and spaces
> 
> Added appropriate error codes around this check
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3a609786a 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> bc9fe2a2e 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
> f66165050 
> 
> 
> Diff: https://reviews.apache.org/r/67148/diff/2/
> 
> 
> Testing
> -------
> 
> PreCommit: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/408/console
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Reply via email to