----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68168/#review206815 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java Lines 932 (patched) <https://reviews.apache.org/r/68168/#comment289899> consider moving updateModificationMetadata(instanceVertex); outside the for loop. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java Lines 937 (patched) <https://reviews.apache.org/r/68168/#comment289900> No usage of this method? server-api/src/main/java/org/apache/atlas/RequestContextV1.java Lines 41 (patched) <https://reviews.apache.org/r/68168/#comment289895> better name maybe? shouldUpdateModificationTimestamp => doModificationTimestampUpdate - Sarath Subramanian On Aug. 2, 2018, 9:59 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68168/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2018, 9:59 a.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-2805 > https://issues.apache.org/jira/browse/ATLAS-2805 > > > Repository: atlas > > > Description > ------- > > **Approach** > As described in the JIRA. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 25c91be60a052d572c92f1a2cba77471d3819000 > server-api/src/main/java/org/apache/atlas/RequestContextV1.java > 2123166518636ce818ab3e73f4a99c07495124d4 > > > Diff: https://reviews.apache.org/r/68168/diff/1/ > > > Testing > ------- > > **Tests** > Functional tests. > > > Thanks, > > Ashutosh Mestry > >
