> On Aug. 2, 2018, 6:11 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > > Lines 932 (patched) > > <https://reviews.apache.org/r/68168/diff/1/?file=2066470#file2066470line932> > > > > consider moving updateModificationMetadata(instanceVertex); outside the > > for loop.
I want the update to happen for each vertex, hence it is inside. > On Aug. 2, 2018, 6:11 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > > Lines 937 (patched) > > <https://reviews.apache.org/r/68168/diff/1/?file=2066470#file2066470line937> > > > > No usage of this method? This will be used as part of cluster update during incremental export. > On Aug. 2, 2018, 6:11 p.m., Sarath Subramanian wrote: > > server-api/src/main/java/org/apache/atlas/RequestContextV1.java > > Lines 41 (patched) > > <https://reviews.apache.org/r/68168/diff/1/?file=2066471#file2066471line41> > > > > better name maybe? > > > > shouldUpdateModificationTimestamp => doModificationTimestampUpdate should is a question, do is a action, hence should. hope this makes sense. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68168/#review206815 ----------------------------------------------------------- On Aug. 2, 2018, 4:59 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68168/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2018, 4:59 p.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-2805 > https://issues.apache.org/jira/browse/ATLAS-2805 > > > Repository: atlas > > > Description > ------- > > **Approach** > As described in the JIRA. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 25c91be60a052d572c92f1a2cba77471d3819000 > server-api/src/main/java/org/apache/atlas/RequestContextV1.java > 2123166518636ce818ab3e73f4a99c07495124d4 > > > Diff: https://reviews.apache.org/r/68168/diff/1/ > > > Testing > ------- > > **Tests** > Functional tests. > > > Thanks, > > Ashutosh Mestry > >
