----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68312/#review207139 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java Line 329 (original), 333 (patched) <https://reviews.apache.org/r/68312/#comment290382> Shouldn't MAP and ARRAY types be updated to handle soft-references? For example, type=array<EntityType>, type=map<string,EntityType>. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java Lines 345 (patched) <https://reviews.apache.org/r/68312/#comment290371> Shouldn't this be "!(ctx.getValue() instanceof AtlasObjectId)" - missing '!'? - Madhan Neethiraj On Aug. 12, 2018, 9:48 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68312/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2018, 9:48 p.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-2813 > https://issues.apache.org/jira/browse/ATLAS-2813 > > > Repository: atlas > > > Description > ------- > > **Approach** > - Add _options_ field to _AtlasAttributeDef_. > - Implement support in _AtlasStructDefStore_. > - Update _EntityGraphMapper_ > - Update _EntityGraphRetriever_ > - Supports array of objects and objects. > > **Usage** > See attached JSON. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > 137fb30746730cc4d1842891987c342a1bc17af7 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 9e7a119a3abfb50401f9747dad1ffa55facc51ed > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > a243fd79cab685174f3a90c5093e84e9f9fa782a > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java > PRE-CREATION > repository/src/test/resources/json/rdbms-db.json PRE-CREATION > repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/68312/diff/1/ > > > Testing > ------- > > **Unit tests** > Additional tests. > > > File Attachments > ---------------- > > rdbms-db.json > > https://reviews.apache.org/media/uploaded/files/2018/08/12/1f45deeb-55d7-4c68-8640-ca184cf08a2c__rdbms-db.json > TypesDef with softRef > > https://reviews.apache.org/media/uploaded/files/2018/08/12/e1e7a8c1-13b5-453a-b240-9217a723dd15__typesDef-soft-ref.json > > > Thanks, > > Ashutosh Mestry > >
