----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68312/#review207198 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java Lines 353 (patched) <https://reviews.apache.org/r/68312/#comment290496> Instead of updating 'ctx' and calling mapPrimitiveValue(ctx), it will be cleaner to simply call the following from here: AtlasGraphUtilsV1.setProperty(ctx.getReferringVertex(), ctx.getVertexProperty(), softRefValue); Also, after above update, remove method AttributeMutationContext.setValue(). repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java Line 767 (original), 790 (patched) <https://reviews.apache.org/r/68312/#comment290497> How are the 'removed' map entries cleaned up in case of 'softReferences'? repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java Line 852 (original), 875 (patched) <https://reviews.apache.org/r/68312/#comment290498> How are the 'removed' array elements cleaned up in case of 'softReferences'? repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 481 (patched) <https://reviews.apache.org/r/68312/#comment290489> consider changing return type from "Object" to "Map<String, AtlasObjectId>" repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 505 (patched) <https://reviews.apache.org/r/68312/#comment290490> consider changing return type from "Object" to "List<AtlasObjectId>" repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 508 (patched) <https://reviews.apache.org/r/68312/#comment290492> Consider handling 'list == null' here (similar to line #483 above)? repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 520 (patched) <https://reviews.apache.org/r/68312/#comment290491> consider changing return type from "Object" to "AtlasObjectId" repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 522 (patched) <https://reviews.apache.org/r/68312/#comment290493> Consider handling 'rawValue == null' here (similar to line #483 above)? repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 526 (patched) <https://reviews.apache.org/r/68312/#comment290494> Consider handling 'rawValue == null' here (similar to line #483 above)? repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 528 (patched) <https://reviews.apache.org/r/68312/#comment290495> Consider adding a WARN log here. - Madhan Neethiraj On Aug. 14, 2018, 12:02 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68312/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2018, 12:02 a.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-2813 > https://issues.apache.org/jira/browse/ATLAS-2813 > > > Repository: atlas > > > Description > ------- > > **Approach** > - Add _options_ field to _AtlasAttributeDef_. > - Implement support in _AtlasStructDefStore_. > - Update _EntityGraphMapper_ > - Update _EntityGraphRetriever_ > - Supports array of objects and objects. > > **Usage** > See attached JSON. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > 9dba1c06fa5548470056cf8cf095f3d2744650b0 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 381191986df81d691e2598d4760d7999344dc630 > > > Diff: https://reviews.apache.org/r/68312/diff/4/ > > > Testing > ------- > > **Unit tests** > Tests verify object, array<object>, map<string,object> cases. > > **Functional tests** > - Quick Start > - Entity creation via REST APIs. > - Entity creation via APIs. > > > File Attachments > ---------------- > > rdbms-db.json > > https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json > typesDef-soft-ref.json > > https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json > > > Thanks, > > Ashutosh Mestry > >
