----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68312/#review207378 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Aug. 15, 2018, 10:58 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68312/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2018, 10:58 p.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-2813 > https://issues.apache.org/jira/browse/ATLAS-2813 > > > Repository: atlas > > > Description > ------- > > **Approach** > - Add _options_ field to _AtlasAttributeDef_. > - Implement support in _AtlasStructDefStore_. > - Update _EntityGraphMapper_ > - Update _EntityGraphRetriever_ > - Supports array of objects and objects. > > **Usage** > See attached JSON. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java > b32c092557b845482a50ca302e102f0b69c8b860 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 381191986df81d691e2598d4760d7999344dc630 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 81b553e6efa60fee3fc75334b3c9da8611d41a9d > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java > 856f38347ea83d95b7095ac40f39c51dbd869d05 > > > Diff: https://reviews.apache.org/r/68312/diff/6/ > > > Testing > ------- > > **Unit tests** > Tests verify object, array<object>, map<string,object> cases. > > **Functional tests** > - Quick Start > - Entity creation via REST APIs. > - Entity creation via APIs. > > > File Attachments > ---------------- > > rdbms-db.json > > https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json > typesDef-soft-ref.json > > https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json > > > Thanks, > > Ashutosh Mestry > >
