----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68792/#review208830 -----------------------------------------------------------
Test will need to be updated once helper method is added. intg/src/main/java/org/apache/atlas/entitytransform/Action.java Line 87 (original), 94 (patched) <https://reviews.apache.org/r/68792/#comment293041> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Action.java Line 91 (original), 98 (patched) <https://reviews.apache.org/r/68792/#comment293042> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Action.java Line 95 (original), 102 (patched) <https://reviews.apache.org/r/68792/#comment293043> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Action.java Line 99 (original), 106 (patched) <https://reviews.apache.org/r/68792/#comment293044> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Action.java Line 103 (original), 110 (patched) <https://reviews.apache.org/r/68792/#comment293045> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Action.java Lines 158 (patched) <https://reviews.apache.org/r/68792/#comment293046> Unnecessary variable. Consider removing. intg/src/main/java/org/apache/atlas/entitytransform/Condition.java Line 82 (original), 91 (patched) <https://reviews.apache.org/r/68792/#comment293047> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Condition.java Line 86 (original), 95 (patched) <https://reviews.apache.org/r/68792/#comment293048> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Condition.java Line 90 (original), 99 (patched) <https://reviews.apache.org/r/68792/#comment293049> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Condition.java Line 94 (original), 103 (patched) <https://reviews.apache.org/r/68792/#comment293050> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Condition.java Line 98 (original), 107 (patched) <https://reviews.apache.org/r/68792/#comment293051> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Condition.java Line 102 (original), 111 (patched) <https://reviews.apache.org/r/68792/#comment293052> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Condition.java Line 106 (original), 115 (patched) <https://reviews.apache.org/r/68792/#comment293053> Remove context here. intg/src/main/java/org/apache/atlas/entitytransform/Condition.java Line 257 (original), 259 (patched) <https://reviews.apache.org/r/68792/#comment293054> Remove context here. intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java Line 338 (original), 337 (patched) <https://reviews.apache.org/r/68792/#comment293055> Collections.singletonMap are repetitive. Consider adding helper method: static AttributeTransform create(String conditionLhs, String conditionRhs, String actionLhs, String actionRhs) { return new AttributeTransform(Collections.singletonMap(conditionLhs, conditionRhs), Collections.singletonMap(actionLhs, actionRhs)); } - Ashutosh Mestry On Sept. 21, 2018, 12:33 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68792/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2018, 12:33 a.m.) > > > Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval > bhatt, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-2882 > https://issues.apache.org/jira/browse/ATLAS-2882 > > > Repository: atlas > > > Description > ------- > > - refactored import transformer creation to set context in constructor > - fixed incorrect ObjectIdEquals.matches() > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/entitytransform/Action.java fa1855893 > > intg/src/main/java/org/apache/atlas/entitytransform/AtlasEntityTransformer.java > e9b2afdf7 > intg/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java > dd6c66539 > intg/src/main/java/org/apache/atlas/entitytransform/Condition.java > 174b9b48b > intg/src/main/java/org/apache/atlas/entitytransform/NeedsContext.java > 5c16bcfbc > > intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java > c76f95916 > > > Diff: https://reviews.apache.org/r/68792/diff/1/ > > > Testing > ------- > > Pre-commit tests run - > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/678/ > > > Thanks, > > Madhan Neethiraj > >
