----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68792/#review208832 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/entitytransform/Action.java Line 87 (original), 94 (patched) <https://reviews.apache.org/r/68792/#comment293058> Though the context is not used in many actions and conditions, I think it is better to keep this consistent across all implementations. Can improve readability (since implementations wouldn't different in few common things - like context). intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java Line 338 (original), 337 (patched) <https://reviews.apache.org/r/68792/#comment293057> Given this is unit test, such refactoring is not critical; and in many tests, it might be useful to explicitly see the values right here, instead of looking else where. - Madhan Neethiraj On Sept. 21, 2018, 12:33 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68792/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2018, 12:33 a.m.) > > > Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval > bhatt, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-2882 > https://issues.apache.org/jira/browse/ATLAS-2882 > > > Repository: atlas > > > Description > ------- > > - refactored import transformer creation to set context in constructor > - fixed incorrect ObjectIdEquals.matches() > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/entitytransform/Action.java fa1855893 > > intg/src/main/java/org/apache/atlas/entitytransform/AtlasEntityTransformer.java > e9b2afdf7 > intg/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java > dd6c66539 > intg/src/main/java/org/apache/atlas/entitytransform/Condition.java > 174b9b48b > intg/src/main/java/org/apache/atlas/entitytransform/NeedsContext.java > 5c16bcfbc > > intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java > c76f95916 > > > Diff: https://reviews.apache.org/r/68792/diff/1/ > > > Testing > ------- > > Pre-commit tests run - > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/678/ > > > Thanks, > > Madhan Neethiraj > >
