-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69494/
-----------------------------------------------------------

(Updated Dec. 5, 2018, 3:43 p.m.)


Review request for atlas.


Changes
-------

Addressed issues from first review - did not change event generation 
considerations as Atlas already produces multiple notifications per delete, and 
a notification is needed on a soft delete and on a hard delete. I would suggest 
that event duplication is addressed in a separate JIRA that would suggest that 
a dedicated event type is introduced for a HARD delete - as this is a different 
operation to a SOFT delete.


Repository: atlas


Description
-------

ATLAS-2985: critical fixes for delete handlers and relationship dtore


Diffs (updated)
-----

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 c57e30ab5cdb34aee1cb13c463b1b0af827d2a2e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
 edf1eed4c3efdd41f77155e51c8f2908b3dbbab2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 86cc98cda61d85954fd227501d691e3a3b542611 


Diff: https://reviews.apache.org/r/69494/diff/2/

Changes: https://reviews.apache.org/r/69494/diff/1-2/


Testing
-------

Tested with full run of Egeria CTS suite.


Thanks,

Graham Wallis

Reply via email to