----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69494/#review211058 -----------------------------------------------------------
> did not change event generation considerations as Atlas already produces > multiple notifications per delete Every entity delete must result in a single entity-delete notification. If you see multiple entity-delete notifications being sent, please add details. That needs to be fixed; else applications that process the notifications can end up with incorrect state. > a notification is needed on a soft delete and on a hard delete. I am not certain of this need. Splitting current entity-delete event into entity-soft-delete and entity-hard-delete will be a breaking change for existing applications (like Ranger TagSync) that depend on current event notifications. > I would suggest that event duplication is addressed in a separate JIRA To avoid breaking existing event consumers, it is critcal that Atlas doesn't send multiple entity-delete events for an entity. Please make sure that no entity-delete event is sent out while hard-deleting an entity in soft-deleted state. - Madhan Neethiraj On Dec. 5, 2018, 3:43 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69494/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2018, 3:43 p.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > ATLAS-2985: critical fixes for delete handlers and relationship dtore > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > c57e30ab5cdb34aee1cb13c463b1b0af827d2a2e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java > edf1eed4c3efdd41f77155e51c8f2908b3dbbab2 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java > 86cc98cda61d85954fd227501d691e3a3b542611 > > > Diff: https://reviews.apache.org/r/69494/diff/2/ > > > Testing > ------- > > Tested with full run of Egeria CTS suite. > > > Thanks, > > Graham Wallis > >
