----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69846/#review212366 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Line 724 (original), 742 (patched) <https://reviews.apache.org/r/69846/#comment298143> for OBJECT_ID_TYPE attributes, 'ret' is populated only when 'includeReferences=true'; else 'ret' is set to true. In case of ARRAY and MAP, soft-ref methods are not passed 'includeReferences' flag; so mapVertexToArrayForSoftRef() and mapVertexToMapForSoftRef() will return object-ids. Please review and make this consistent. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Line 831 (original), 849 (patched) <https://reviews.apache.org/r/69846/#comment298144> It will be efficient to bail out at line #149, when includeReferences=false, as shown below: if (isReference(mapValueType)) { if (includeReferences) { // lines #849 - #863 go here } } else { ret = getPrimitiveMap(entityVertex, attribute.getVertexPropertyName()); } Similarly review and update mapVertexToArray() as well. - Madhan Neethiraj On Jan. 28, 2019, 12:56 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69846/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2019, 12:56 a.m.) > > > Review request for atlas, Ashutosh Mestry, madhan, and Nixon Rodrigues. > > > Bugs: ATLAS-3036 > https://issues.apache.org/jira/browse/ATLAS-3036 > > > Repository: atlas > > > Description > ------- > > Improve FullTextMapper performance during entity retrieval > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java > 77cecff16 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 7f5e5be3d > > > Diff: https://reviews.apache.org/r/69846/diff/1/ > > > Testing > ------- > > Validated throught REST API: > > > "fullTextMapping": 60383 msecs (Before patch) > "fullTextMapping": 20261 msecs (After patch) > > > Thanks, > > Sarath Subramanian > >
