----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69846/#review212461 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Line 753 (original), 773 (patched) <https://reviews.apache.org/r/69846/#comment298226> Consider avoiding retrieval of 'softRefVal' (line #767) when includeReferences=false. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Line 772 (original), 794 (patched) <https://reviews.apache.org/r/69846/#comment298225> Consider avoiding retrieval of 'softRefVal' (line #788) when includeReferences=false. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Line 830 (original), 852 (patched) <https://reviews.apache.org/r/69846/#comment298224> isReference() might return 'true' for struct attribute as well. includeReference flag should only be used for object-id reference attributes. Please review and update. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Line 864 (original), 888 (patched) <https://reviews.apache.org/r/69846/#comment298223> Wouldn't this cause to return null for non-object-id type attribute also? Please review and update. - Madhan Neethiraj On Jan. 29, 2019, 5:46 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69846/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2019, 5:46 a.m.) > > > Review request for atlas, Ashutosh Mestry, madhan, and Nixon Rodrigues. > > > Bugs: ATLAS-3036 > https://issues.apache.org/jira/browse/ATLAS-3036 > > > Repository: atlas > > > Description > ------- > > Improve FullTextMapper performance during entity retrieval > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java > 77cecff16 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 7f5e5be3d > > > Diff: https://reviews.apache.org/r/69846/diff/2/ > > > Testing > ------- > > Validated throught REST API: > > > "fullTextMapping": 60383 msecs (Before patch) > "fullTextMapping": 20261 msecs (After patch) > > > Thanks, > > Sarath Subramanian > >
