> On May 28, 2019, 5:58 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > > Lines 23 (patched) > > <https://reviews.apache.org/r/70708/diff/1/?file=2146553#file2146553line23> > > > > nit: unused imports, consider removing them.
done > On May 28, 2019, 5:58 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > > Lines 565 (patched) > > <https://reviews.apache.org/r/70708/diff/1/?file=2146553#file2146553line565> > > > > cast startTime as string value; same for line #568 directly casting it to long does not work. I change the type to "Long", and call its.toString() instead > On May 28, 2019, 5:58 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java > > Line 114 (original), 114 (patched) > > <https://reviews.apache.org/r/70708/diff/1/?file=2146554#file2146554line114> > > > > surround with LOG.isDebugEnabled(); same for line #121 see comment at https://stackoverflow.com/questions/105852/conditional-logging-with-minimal-cyclomatic-complexity/105908#105908 and `https://stackoverflow.com/questions/963492/in-log4j-does-checking-isdebugenabled-before-logging-improve-performance` `Better yet is to use a more up-to-date logging framework where the log statements take a format specification and a list of arguments to be substituted by the logger—but "lazily," only if the logger is enabled.` that is what I did. The overhead only happens if debug logging is enabled. So I don't need to check `LOG.isDebugEnabled()` - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/#review215546 ----------------------------------------------------------- On May 23, 2019, 9:11 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70708/ > ----------------------------------------------------------- > > (Updated May 23, 2019, 9:11 p.m.) > > > Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath > Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3133 adds a new feature to track metadata for different executions of > the same process in Atlas. Need to add this in Impala integration > > > Diffs > ----- > > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java > 88faace > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java > 232a569 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > 63c5f87 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java > 0dc520c > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java > 0138d88 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > 033a518 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java > 86801e3 > > > Diff: https://reviews.apache.org/r/70708/diff/1/ > > > Testing > ------- > > Integration tests > > > Thanks, > > Na Li > >
