> On May 24, 2019, 8:14 p.m., Aadarsh Jajodia wrote: > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > > Lines 201-205 (patched) > > <https://reviews.apache.org/r/70708/diff/1/?file=2146556#file2146556line201> > > > > Can we also add a unit test which produces more than one execution?
added new test with multiple process executions - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/#review215511 ----------------------------------------------------------- On May 28, 2019, 9:19 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70708/ > ----------------------------------------------------------- > > (Updated May 28, 2019, 9:19 p.m.) > > > Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath > Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3133 adds a new feature to track metadata for different executions of > the same process in Atlas. Need to add this in Impala integration > > > Diffs > ----- > > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/ImpalaLineageTool.java > 7c9abc8 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java > 88faace > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaIdentifierParser.java > b9d6cbb > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java > 232a569 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > c7604ba > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java > 3071576 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java > 0138d88 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > 033a518 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java > 86801e3 > > addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect1.json > PRE-CREATION > > addons/impala-bridge/src/test/resources/impalaMultipleInsertIntoAsSelect2.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70708/diff/2/ > > > Testing > ------- > > Integration tests > > > Thanks, > > Na Li > >
