> On May 29, 2019, 12:54 p.m., Sarath Subramanian wrote:
> > Ship It!

Nixon, can you address Ashutosh's comment and update the review.


- Sarath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70745/#review215587
-----------------------------------------------------------


On May 29, 2019, 6:30 a.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70745/
> -----------------------------------------------------------
> 
> (Updated May 29, 2019, 6:30 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3243
>     https://issues.apache.org/jira/browse/ATLAS-3243
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch provides changes required to support UI access Atlas via Trusted 
> Knox proxy, there some changes required in AtlasAuthenticationFilter.
> 
> 
> Diffs
> -----
> 
>   
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
>  b6ed545e6 
> 
> 
> Diff: https://reviews.apache.org/r/70745/diff/1/
> 
> 
> Testing
> -------
> 
> Tested Atlas different scenario's
> 
> 1) curl call with kerberos.
> 2) curl Simple basic heaeder
> 3) Atlas login page.
> 4) curl with trusted proxy 
> 4) Atlas UI with Trusted Proxy with Knox shiroprovider.
> 5) Atlas UI with Trusted proxy with KnoxSSOCoookieProvider.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Reply via email to