----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70745/#review215684 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Lines 347 (patched) <https://reviews.apache.org/r/70745/#comment302478> nit: remove additional new line(s). Same for line #763, 764 - Sarath Subramanian On June 4, 2019, 7:52 a.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70745/ > ----------------------------------------------------------- > > (Updated June 4, 2019, 7:52 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, > and Sarath Subramanian. > > > Bugs: ATLAS-3243 > https://issues.apache.org/jira/browse/ATLAS-3243 > > > Repository: atlas > > > Description > ------- > > This patch provides changes required to support UI access Atlas via Trusted > Knox proxy, there some changes required in AtlasAuthenticationFilter. > > > Diffs > ----- > > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > 782b5a06c > > > Diff: https://reviews.apache.org/r/70745/diff/2/ > > > Testing > ------- > > Tested Atlas different scenario's > > 1) curl call with kerberos. > 2) curl Simple basic heaeder > 3) Atlas login page. > 4) curl with trusted proxy > 4) Atlas UI with Trusted Proxy with Knox shiroprovider. > 5) Atlas UI with Trusted proxy with KnoxSSOCoookieProvider. > > > Thanks, > > Nixon Rodrigues > >
