> On May 31, 2019, 5:50 p.m., Le Ma wrote:
> > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java
> > Lines 107 (patched)
> > <https://reviews.apache.org/r/70759/diff/3/?file=2147400#file2147400line107>
> >
> >     Hello Lina, thanks for doing this. There is one case you might need to 
> > consider - CreateImpalaProcess will be called by cases like 
> > QUERY/ALTERVIEW_AS/CREATETABLE_AS_SELECT/CREATEVIEW. However, ddl might not 
> > need to capture QUERY case.
> >     
> >     -Thanks

updated. only generate ddl for ddl commands


> On May 31, 2019, 5:50 p.m., Le Ma wrote:
> > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java
> > Lines 93 (patched)
> > <https://reviews.apache.org/r/70759/diff/3/?file=2147403#file2147403line93>
> >
> >     Please align '=' to match the code-style. and please check other 
> > places. -Thanks.

done


- Na


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70759/#review215618
-----------------------------------------------------------


On May 31, 2019, 4:02 a.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70759/
> -----------------------------------------------------------
> 
> (Updated May 31, 2019, 4:02 a.m.)
> 
> 
> Review request for atlas, madhan and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3197 introduced a new feature on Hive integration. It introduced new 
> model called Hive_table_ddl and hive_db_ddl which are used to track commands 
> that are executed either on a table entity or bd entity. DDL entities will be 
> added to a table/db entity through relationshipAttribute call HIVE_DB_TO_DDL 
> and hive_tb_to_ddl. Every time when a new command is executed, a new ddl 
> entity will be created, it will append to the existing ddlQueries field if a 
> table/db has already been created. Once a table/db is deleted, all these 
> relationship attributes will be deleted as well.
> 
> We need to support this new feature on Impala integration.
> 
> 
> Diffs
> -----
> 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java
>  d241b6a 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java
>  b7506a4 
>   
> addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/ImpalaDataType.java
>  10ce448 
>   
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java
>  b8cbf6b 
>   
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java
>  7f9a534 
>   
> addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java
>  6156208 
>   addons/models/0000-Area0/0010-base_model.json d14b227 
>   addons/models/1000-Hadoop/1030-hive_model.json 417c4c5 
>   addons/models/1000-Hadoop/1090-impala_model.json 24eb5db 
> 
> 
> Diff: https://reviews.apache.org/r/70759/diff/3/
> 
> 
> Testing
> -------
> 
> add check for ddl entities in integration tests
> 
> 
> Thanks,
> 
> Na Li
> 
>

Reply via email to